Skip to content

feat: remove the "Contributors" list and re-arrange the "Help" info#4044

Merged
4 commits merged intomasterfrom
unknown repository
Aug 15, 2021
Merged

feat: remove the "Contributors" list and re-arrange the "Help" info#4044
4 commits merged intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 14, 2021 •
edited by ghost
Loading

  1. Make "Help" Info in verticle in ul...li style.
  2. remove the contributors' list, this will be discussed at (feat: Is is necessary to add "Contributors" as a random mode in "Index" of nodejs.org? #4043).
  3. Ref from "README.md" in "CONTRIBUTING.md", because for newbies, they should know how to step-by-step building the nodejs.org.
  4. Considering the random contributor is related to node/node.dev (https://nodejs.dev/, at the footer) instead of node.org itself, so remove it here.

Ref: #4000

捕获

Maledong and others added 2 commits August 14, 2021 10:23
Trott
Trott reviewed Aug 14, 2021
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
Trott
Trott approved these changes Aug 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the help info easier to see/find. 👍

Maledong and others added 2 commits August 14, 2021 11:07
@Trott
Update CONTRIBUTING.md
a040e44 
Co-authored-by: Rich Trott <rtrott@gmail.com>
Merge branch 'master' into newStyle
4fb7394
@ghost ghost merged commit 6036ac7 into nodejs:master Aug 15, 2021
@ghost ghost deleted the newStyle branch August 15, 2021 08:45
@XhmikosR
Copy link
Copy Markdown
Contributor

XhmikosR commented Aug 19, 2021

This is broken on mobile...

@Trott
Copy link
Copy Markdown
Member

Trott commented Aug 19, 2021

This is broken on mobile...

@XhmikosR It looks like the footer can be wider than the viewport and (in a sufficiently narrow viewport such as on a mobile device) there's no way to scroll right to see the links on the right hand side of the footer.

Is that what you're talking about? Is there something more as well that I'm missing?

@Trott Trott mentioned this pull request Aug 19, 2021
Closed
@Trott
Copy link
Copy Markdown
Member

Trott commented Aug 19, 2021

This is broken on mobile...

@XhmikosR It looks like the footer can be wider than the viewport and (in a sufficiently narrow viewport such as on a mobile device) there's no way to scroll right to see the links on the right hand side of the footer.

Is that what you're talking about? Is there something more as well that I'm missing?

Created new issue for this at #4060.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XhmikosR @Trott